• JackbyDev@programming.devEnglish
    12·
    3 months ago

    Which of these do you prefer?

    A?

    @Test
  public void turnOnLoTempAlarmAtThreshold() throws Exception {
    wayTooCold();
    assertEquals(“HBchL”, hw.getState());
  }

    Or B?

    @Test
  public void turnOnLoTempAlarmAtThreashold() throws Exception {
    hw.setTemp(WAY_TOO_COLD);
    controller.tic();
    assertTrue(hw.heaterState());
    assertTrue(hw.blowerState());
    assertFalse(hw.coolerState());
    assertFalse(hw.hiTempAlarm());
    assertTrue(hw.loTempAlarm());
  }
    Uncle Bob's Clean Code suggests

    Option A

    • magic_lobster_party@kbin.run
      11·
      3 months ago

      I almost pulled my hair out when I read that section. One is super obvious without any prior experience with the code. The other is an obscure abomination only he can understand. He’s obviously super proud of his abomination and thinks it’s a prime example of “clean code”.

    • RonSijm@programming.devOP
      34·
      3 months ago

      I’ve started to prefer option A to be honest.

      In C# I’m using Verify - So I prefer to just use Verify(state); and compare the entire state against a json saved state, instead of manually verifying every individual property

      • magic_lobster_party@kbin.run
        5·
        3 months ago

        His idea is that it’s faster to read that short string once you learn how to read it. But then you need to learn how to read it.

        In my experience, every time I thought of something clever like this, I’ll almost always regret it a month later when I revisit the code.