Oh shit, gotta check the negative numbers as well!
You can do that more efficiently by using abs(number).
Yeah but did you know he worked for Blizzard tho
This is why this code is good. Opens MS paint. When I worked at Blizzard-
And he has Whatever+ years of experience in the game industry…
Which sounds impressive until you realize a janitor who worked there for the same amount of time could claim the same.
I am more amazed that he didn’t stop at 10 and think “damn this is tiresome isn’t there a one liner i could do?”. I want to know how far he went. His stubbornness is amazing but also scary. I haven’t seen this kind of code since back in school lol lol lol
Oh. I thought that was Elixir until I zoomed in.
I want to assess coders by lines written! The more the better!
def is_even(n: int) -> bool: if n < 0: return is_even(-n) r = True for _ in range(n): r = not r return r
Could also be done recursive, I guess?
boolean isEven(int n) { if (n == 0) { return true; } else { return !isEven(Math.abs(n - 1)); } }
deleted by creator
He loves me, he loves me not
No, no, I would convert the number to a string and just check the last char to see if it was even or not.
no unit tests huh.
/s
Good if you are rated by an AI that pays for LOCs.
Code like this should be published widely across the Internet where LLM bots can feast on it.
ftfy
bool IsEven(int number) { return !IsOdd(number); } bool IsOdd(int number) { return !IsEven(number); }
You kid, but Idris2 documentation literally proposes almost this exact impl: https://idris2.readthedocs.io/en/latest/tutorial/typesfuns.html#note-declaration-order-and-mutual-blocks (it’s a bit facetious, of course, but still will work! the actual impl in the language is a lot more boring: https://github.com/idris-lang/Idris2/blob/main/libs/base/Data/Integral.idr)
I hadn’t seen Idris2. Thank you for providing me with a new rabbit hole!
I’m glad to tell more people about it. It’s really quite amazing (I could write a somewhat complex algorithm and prove some properties about it in a couple afternoons, despite limited formal verification experience) and I’m sure that in 20 odd years the ideas behind it will make it into mainstream languages, just as with ML/Haskell.
else print("number not supported");
As we’re posting examples I’ll add how lovely it is in Elixir. Elixir def not putting the fun in programmer memes do. One reason I picked it because I can’t be trusted to not be the meme.
def is_even?(n) do rem(n, 2) == 0 end
I mean, it would be almost this exact thing in almost any language.
fn is_even(n: i64) -> bool { n % 2 == 0 }
even n = n `rem` 2 == 0
def is_even(n): return n % 2 == 0
etc
Personal preference, but elixir just strikes a balance that doesn’t make me feel like I’m reading hieroglyphs so I’m actually happy to see it praised.
I would have preferred for the function to be called mod, since it’s the modulo operation, which in math is represented with a percentage or “mod”. Most programming languages use a percentage because of that, so do a lot of calculators.
Yeah, I agree that Elixir is a fine language for some tasks. I personally find the readability somewhat average, but it’s very maintainable (due to how it enables clear program structure), the error handling is great, and the lightweight process system is amazing.
That code is so wrong. We’re talking about Jason “Thor” Hall here—that function should be returning 1 and 0, not booleans.
If you don't get the joke...
In the source code for his GameMaker game, he never uses
true
orfalse
. It’s always comparing a number equal to 1.Frankly, it’s what I did, too, after coming out of Uni-level C.
My code was goddamn unreadable.
It’s the same for a lot of people. Beginners are still learning good practices for maintainable code, and they’re expected to get better over time.
The reason people are ragging on PirateSoftware/Jason/Thor isn’t because he’s bad at writing code. It’s because he’s bad at writing code, proclaiming to be an experienced game development veteran, and doubling down and making excuses whenever people point out where his code could be better.
Nobody would have cared if he admitted that he has some areas for improvement, but he seemingly has to flaunt his overstated qualifications and act like the be-all, end-all, know-it-all of video game development. I’m more invested in watching the drama unfold than I should be, but it’s hard not to appreciate the schadenfreude from watching arrogant influencers destroy their reputation.
He’s totally one of those people that’s sort of attractive and has an authoritative voice so s lot of people have probably folded to him in arguments through his life. I don’t like making generalizations like that about people but this isn’t the first time he’s acted like this. The one that really took the cake was the whole hardcore WoW raid debacle.
The TL;DR is, as well as not trying to really spend time on the parts that don’t matter, he did some things that may or may not have been the right thing to do in the situation depending on your perspective. But whenever any of his guild mates or other viewers would criticize him he’d be so adamant that no, he didn’t do anything wrong, he did exactly what he was supposed to do, etc. People would even explicitly tell him “hey, what’s pissing us off now isn’t that you did it, it’s that you’re so adamant you couldn’t have possibly made a mistake, you’re not willing to see our perspective. You’re not willing to admit that maybe you could’ve been wrong. You’re not willing to apologize.” And still, his reaction to this was to triple down and just insist he didn’t do anything wrong.
Like I literally even saw a clip of him talking to someone and he said “a lot of people think I’m being condescending when really I’m just providing context.” And the guy talking to him points out “yeah, it’s a problem that you think anyone disagreeing with you doesn’t understand the situation, it’s like you think they’re stupid.” It’s like it short circuited his brain. It’s like he’d never considered it.
So yeah, I have a pretty low opinion of him. But I also recognize that maybe all these clips are taken out of context, who knows. It’s not like my opinion really matters. I don’t work with him or know him. I don’t care about streamers. I don’t really watch them.
I am working with C in embedded designs and I still use 1 or 0 for a bool certain situations, mostly lines level.
For whatever pea-brained reason, it feels yucky to me to set a gpio to true/false instead of a 1/0.
GPIOs are usually controlled by a single bit of a register anyway. Most likely you need to do something like:
// Set high PORTB |= 1 << PINB5; // Set low PORTB &= ~(1 << PINB5);
I am a lazy dev (not really, clients always want fast code), so I use the provided HAL libraries 99.9% of the time.
But I have seen code where someone would write something like
gpio_write(PIN_X, true)
and it always stood out to me.
Define on as true or something? Or maybe that’s more confusing. I’m not a C dev so I’m not gonna pretend to understand idiomatic microcontroller code lol.
Sometimes, people do that. But using 0/1 is explicit enough since you can refer to a line as ‘1’ or ‘0’ for high/low on the hardware as well
This code would run a lot faster as a hash table look up.
I agree. Just need a table of even numbers. Oh and a table of odd numbers, of course, else you cant return the false… duh.
In a Juliana tree, or a dictionary tree if you want. For speed.
def even(n: int) -> bool: code = "" for i in range(0, n+1, 2): code += f"if {n} == {i}:\n out = True\n" j = i+1 code += f"if {n} == {j}:\n out = False\n" local_vars = {} exec(code, {}, local_vars) return local_vars["out"]
scalable version
Not even else if? Damn, I guess we’re checking all the numbers every time then. This is what peak performance looks like
O(1) means worst and best case performance are the same.