• BillyClark@piefed.social
    link
    fedilink
    English
    arrow-up
    1
    ·
    edit-2
    7 days ago

    Forgetting AI for a moment, I am always shocked when I am reviewing a coworker’s code and it’s obvious that they themselves didn’t review it.

    Like, they sent me a PR that has a whole shitload of other crap in it. Why should I look at it when you haven’t looked at it? If you don’t review your own review requests, you’re a failure of a programmer human.

    And I would be a failure if I approved such a request.

    Getting back to the post, where is all of the review? The coworker should have reviewed the AI shit, whether it was code or documentation. The person who approved the PR should have reviewed it, as well.

    Every business with more than one programmer should have at least two levels of safeguards against this exact thing happening. More if you include different types of test suites.

    This post describes a fundamentally broken business, regardless of the AI angle, and so it’s good if everything is broken. With such a lack of discipline and principles, I say let the business fail.

    • locuester@lemmy.zip
      link
      fedilink
      English
      arrow-up
      1
      ·
      7 days ago

      Yeah, we are falling into a little bit of this where I work right now. It’s a bit of a change of mindset to begin thinking that you can’t trust a PR even a little. Yes, you should be able to but humans are humans and we get lazy and trusting the magic pattern machine is gonna impact everyone’s life in a lot of ways