A client’s team spent a full week adding a CSV export to their admin panel. Two engineers, clear requirements, maybe a day of actual work. The rest of the time went to understanding existing code well enough to change it safely. That’s what I call codebase drag: when the codebase makes every task take longer than it should. It doesn’t show up in any dashboard or sprint report.

  • bestboyfriendintheworld@sh.itjust.works
    link
    fedilink
    arrow-up
    3
    ·
    edit-2
    8 hours ago

    A good alternative is code presentations.

    You present your changes to a group of engineers. Then discuss it.

    argue

    Yes, it happens too often. That’s a failure of leadership or a social problem.

    Techies often try and fix human and social issues with technology, but that doesn’t always work.

    Code review helps spread knowledge about the code base through the team. Without it, you easily end up with disjointed fiefdoms ruled by petty code lords that don’t share information.

    • the_radness@lemmy.worldB
      link
      fedilink
      arrow-up
      4
      ·
      8 hours ago

      Spreading knowledge and context sharing are exactly why I like code reviews. It should also be something done by more than one person so that information is better disseminated throughout the team.

      • bestboyfriendintheworld@sh.itjust.works
        link
        fedilink
        arrow-up
        2
        ·
        8 hours ago

        Code presentations are great for that.

        One or two people present their code before the merge. Others watch, ask questions, etc. Small changes and improvements can be done immediately. Ideally the change is merged after the presentation. It can speed up things immensely and more people feel ownership. If a simple ticket stays in review for a week, it can be very detrimental.

    • resipsaloquitur@lemmy.world
      link
      fedilink
      arrow-up
      3
      ·
      edit-2
      3 hours ago

      I mean, what we have now is a clique of ideologically-aligned people who insta-approve each other’s bad PRs outside their domain and ignore or jam-up the PRs of people outside their clique.

      You can say it’s a failure of management, but this is the primary tool used by the ideologues. And I’ve seen it used so at various places.

      What I haven’t seen is a real dissemination of knowledge about the code. At least not above and beyond looking at the code and using blame to see the changesets and looking at the associated issues.