A couple years back I got illwinter floorplan [Link[(http://www.illwinter.com/floorplan/) on steam sales. Which for “indoor map” fits my need.
I don’t play D&D, in general do not use “battle map” but still sometimes like to take time to visualise/describe a situation (and because it can be fun to do)

I settled on Campaign Cartographer 3+.

It has a steep learning curve, but seems to be the most powerful tool by far.

I’ve been using Wonderdraft. It’s resource heavy for my little laptop, but it’s easy to use.

I use Gimp and just hand-draw everything. I’ve learned that players don’t really care too much about maps, so going above and beyond with high quality, ultra detailed stuff is wasted effort unless you derive joy from the creation process.

Depends on the Map I want to make and how much time I have.

Worldographer for hexmaps, I’ve tried other programs like Hex Kit but honestly I like Hexographer the most because it is the easiest to read and fastest to get something put together in.

Dungeondraft for Dungeons/Battlemaps, there’s some issues I have with it with how it handles several assets but overall it’s solid and just your assets straight out of the gate are solid.

Wonderdraft for ‘Useless Maps’, this one is for world maps but for the most part I use it to make a map that players might find on a goblin that details their plans to attack a village or a city map in an old style so it is used more to convey an atmosphere.

Honorable mention to dungeonscrawl which I use to just sketch out a dungeon real quick has enough functionality for me.

Inkarnate works great and has a lot of usable styles and assets.

Combination of Inkarnate or GIMP depending on what I need